Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opening search APIs for OrgUnits and Categories #364

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Sep 3, 2024

Description

  • Create API to get Opening Categories;
  • Create API to get Org Units;

Fixes SILVA-486 and SILVA-487

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added unit and integration tests;
  • Eyeball;
  • Real requests through Swagger API;

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-364-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-14-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Sep 3, 2024
Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using swagger works great. Still need to have conversation with Caroline about shortening the list.

@RMCampos RMCampos merged commit 6ffc7e0 into main Sep 4, 2024
16 checks passed
@RMCampos RMCampos deleted the feat/486-487-org-unit-category-apis branch September 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants