Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ESRI WMS tile layer to react leaftlet #343

Merged
merged 15 commits into from
Aug 23, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Aug 6, 2024

Description

Replace WFS By WMS

Fixes SILVA-433

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-343-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-43-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Aug 6, 2024
@DerekRoberts DerekRoberts force-pushed the feat/433-replace-wfs-by-wms branch 2 times, most recently from 894fa27 to e4f1a35 Compare August 6, 2024 15:37
@DerekRoberts DerekRoberts force-pushed the feat/433-replace-wfs-by-wms branch from e4f1a35 to 09b43dd Compare August 6, 2024 15:42
@DerekRoberts DerekRoberts self-assigned this Aug 6, 2024
@DerekRoberts DerekRoberts added the enhancement New feature or request label Aug 6, 2024
@RMCampos RMCampos marked this pull request as ready for review August 8, 2024 18:34
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really slick. Good job! :)

@RMCampos RMCampos merged commit 9b24f02 into main Aug 23, 2024
17 checks passed
@RMCampos RMCampos deleted the feat/433-replace-wfs-by-wms branch August 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants