Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/opening design review #325

Merged
merged 24 commits into from
Jul 4, 2024
Merged

Fix/opening design review #325

merged 24 commits into from
Jul 4, 2024

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Jun 7, 2024

Description

This PR contains design related changes in the Openings component.

Fixes # (SILVA-422)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test Locally with npm

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-325-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-25-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Jazz! 🥇 Some minor changes requested, though.

@jazzgrewal jazzgrewal marked this pull request as ready for review June 20, 2024 21:56
@jazzgrewal jazzgrewal requested a review from DerekRoberts as a code owner June 20, 2024 21:56
@jazzgrewal jazzgrewal force-pushed the fix/openingDesignReview branch from e0e7586 to 39a9d09 Compare June 26, 2024 22:26
@jazzgrewal jazzgrewal requested a review from RMCampos June 27, 2024 18:37
Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job 🚀

@DerekRoberts DerekRoberts enabled auto-merge (squash) July 4, 2024 17:05
@RMCampos RMCampos disabled auto-merge July 4, 2024 17:59
@jazzgrewal jazzgrewal merged commit e9752bd into main Jul 4, 2024
16 checks passed
@jazzgrewal jazzgrewal deleted the fix/openingDesignReview branch July 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants