Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: React warning fixes #323

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore: React warning fixes #323

merged 1 commit into from
Jun 4, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Jun 4, 2024

Description

TL;DR;

  • Fixes warnings when running locally.

Full description

Stopped to look at the charts, understanding why they don't have data locally. Here's why:

  • When we started using the real backend locally, instead of test, no data was fetched from Oracle. In simple words, there's no data locally to be displayed.
  • But when looking into that, some warnings could be noticed. This PR aims on fixing them

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally,

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-323-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-23-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Jun 4, 2024
@RMCampos RMCampos changed the title chore: fixing warnings chore: React warning fixes Jun 4, 2024
Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@RMCampos RMCampos merged commit 3fe646a into main Jun 4, 2024
16 checks passed
@RMCampos RMCampos deleted the fix/missing-chart-data branch June 4, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants