Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): deploymentConfig deprecation, drop imageStreams #318

Merged
merged 6 commits into from
May 24, 2024
Merged

chore(ci): deploymentConfig deprecation, drop imageStreams #318

merged 6 commits into from
May 24, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented May 24, 2024 •
edited
Loading

Devops updates:

  • OpenShift deploymentConfigs have been deprecated, so move to deployments instead
  • Drop imageStreams (simpler!)

@DerekRoberts DerekRoberts changed the title chore(ci): drop imageStreams chore(ci): deploymentConfig deprecation, drop imageStreams May 24, 2024
@DerekRoberts DerekRoberts self-assigned this May 24, 2024
@DerekRoberts DerekRoberts added the enhancement New feature or request label May 24, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review May 24, 2024 05:17
@DerekRoberts DerekRoberts enabled auto-merge (squash) May 24, 2024 05:18
RMCampos
RMCampos approved these changes May 24, 2024
View reviewed changes
Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥇 🎸

Loved the image stream removal, much simpler indeed =D

@DerekRoberts DerekRoberts merged commit 0b876fe into main May 24, 2024
20 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/dropImageStreams branch May 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMCampos RMCampos RMCampos approved these changes

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekRoberts @RMCampos