Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow inline image data loading on caddyfile #315

Closed
wants to merge 9 commits into from

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented May 21, 2024

Description

Fix images and polygons not being loaded in SILVA Map View.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-315-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-15-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this May 21, 2024
@RMCampos RMCampos marked this pull request as ready for review May 21, 2024 17:56
@DerekRoberts DerekRoberts self-assigned this May 21, 2024
@DerekRoberts DerekRoberts added the enhancement New feature or request label May 21, 2024
Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

frontend/Caddyfile Outdated Show resolved Hide resolved
@RMCampos RMCampos requested a review from DerekRoberts May 22, 2024 18:48

@GetMapping("/base-map-layer/{name}")
public String getForestTenureRoadSectionLines(@PathVariable String name) {
return baseMapService.getBaseMapLayer(name);

Check warning

Code scanning / CodeQL

Cross-site scripting Medium

Cross-site scripting vulnerability due to a
user-provided value
.
@RMCampos
Copy link
Author

Closing issue. We'll work with WMS (Web Map Services) instead of WFS (Web Features Services), that has no CORS issues.

@DerekRoberts

@RMCampos RMCampos closed this May 29, 2024
@RMCampos RMCampos deleted the fix/caddy-file-openmaps branch May 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants