Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geospatial opening polygons first steps #308

Merged
merged 19 commits into from
May 21, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented May 10, 2024

Description

  • Displays the selected opening polygon on the map, if any (from BC GW dataset)
  • Displays popup with opening properties, when clicked;
  • Displays a simple layer for demo purposes;

Fixes Jira issue SILVA-236

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-308-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-8-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this May 10, 2024
@RMCampos
Copy link
Author

Needs #309 to be fixed first, before merging this one.

@RMCampos RMCampos marked this pull request as ready for review May 17, 2024 17:08
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Really like that you stuck with this tough one. Bonus points for improving the node dependencies. :D

@RMCampos RMCampos merged commit 7be351f into main May 21, 2024
15 checks passed
@RMCampos RMCampos deleted the feat/236-geospatial-deep-dive-sample branch May 21, 2024 17:51
@webgismd
Copy link

@RMCampos just a comment on this line

export const getInitialLayers = async (): Promise<MapLayer | null> => {
it would be good to get confirmation for the business what they would like to do with the 20 layers they want added.. if we add 20 layers as WFS we will start to have performance issue potential. (support WMS calls with leaflet where appropriate will give you default styles that are approved by the data custodian, scale dependencies, better performance -- with GetMap - to display tiles, and GetFeatureInfo to display attributes) -- not endorsing this specific code but as an example -- https://gist.github.com/rclark/6908938 and https://leafletjs.com/examples/wms/wms.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants