Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: react warnings and login issues #307

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented May 9, 2024

Description

  • Fixed login issue (when the user is already logged in and tried to click the login button);
  • Fixed warnings related to react components and props;
  • Removed the address when clicked on the favourite cards;

Fixes Jira issue SILVA-389

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-307-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-7-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this May 9, 2024
@RMCampos RMCampos merged commit e089457 into main May 15, 2024
14 of 15 checks passed
@RMCampos RMCampos deleted the chore/fix-react-warnings branch May 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants