Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CJS build of Vide's Node API is deprecated #295

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Apr 24, 2024

Description

Handle: The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

Fixes #216

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm ci && npm run build

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-295-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-45-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts self-assigned this Apr 24, 2024
@DerekRoberts DerekRoberts added the bug Something isn't working label Apr 24, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review April 24, 2024 01:49
Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts merged commit debc073 into main Apr 24, 2024
19 checks passed
@DerekRoberts DerekRoberts deleted the chore/viteCJSDeprecation branch April 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

deprecation: CJS build of Node API
2 participants