Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add graceful shutdown and hikari connection pool #274

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Apr 5, 2024

Description

  • Get Hikari Connection Pool back;
  • Add graceful shutdown feature.
  • Remove spring devtools (locally autorestart feature, that may keep connections alive)

Closes #273

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested locally, all configs working properly.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-274-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-24-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-274-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-24-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Apr 5, 2024
@RMCampos RMCampos marked this pull request as ready for review April 5, 2024 17:05
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed. :)

@RMCampos RMCampos merged commit 36601b5 into main Apr 5, 2024
14 checks passed
@RMCampos RMCampos deleted the fix/connection-pool-settings branch April 5, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Hikari Connection pool configuration back
2 participants