Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x-opening-source header #262

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Mar 26, 2024

jira issue silva-373

Description

Add header x-opening-source providing information either where the opening did came from the logged user or not. Possible values are:

  • user-based when openings in the response DID get created by the logged user;
  • not-user-based when openings in the response DID NOT get created by the logged user. In this case, the response body will container no filter by user, but respond with latest ones instead.

Fixes Jira task SILVA-373

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This was tested locally and with unit tests.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-262-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-12-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

jira issue silva-373
@RMCampos RMCampos self-assigned this Mar 26, 2024
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious! :D

@RMCampos RMCampos merged commit 13c35af into main Mar 27, 2024
14 checks passed
@RMCampos RMCampos deleted the feat/373-update-recent-openings-with-header branch March 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants