Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add config maps in the delete oc command #218

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Jan 16, 2024

Description

Add missing config maps.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Will be tested with this PR.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Jan 16, 2024
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did that sneak through? Good catch! :)

@RMCampos RMCampos merged commit 5468385 into main Jan 16, 2024
15 checks passed
@RMCampos RMCampos deleted the ci/add-secret-map-cleaning branch January 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants