Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the caddy file to allow map to load #206

Closed
wants to merge 1 commit into from
Closed

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Jan 10, 2024

Description

Checking is the caddy file fix allows to load the map, tested locally

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Docker Caddy Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@@ -23,7 +23,7 @@
Cache-Control "no-store, no-cache, must-revalidate, proxy-revalidate"
X-Content-Type-Options "nosniff"
Strict-Transport-Security "max-age=31536000"
Content-Security-Policy "base-uri 'self'; connect-src 'self' https://*.gov.bc.ca https://*.amazoncognito.com https://*.cloudfront.net https://cdnjs.cloudflare.com/ https://cognito-idp.ca-central-1.amazonaws.com https://results-ques.netlify.app/api; default-src 'self'; font-src 'self'; frame-src 'self' https://*.gov.bc.ca; img-src 'self' http://www.w3.org/ https://cdnjs.cloudflare.com/ https://www.google.cn/maps/; manifest-src 'self'; media-src 'self'; object-src 'none'; script-src 'unsafe-inline' 'report-sample' 'self' https://cdn.jsdelivr.net/npm/; style-src 'report-sample' 'self' https://cdn.jsdelivr.net/npm/ https://dq9dozspu8y40.cloudfront.net/; style-src-elem 'report-sample' 'self' https://cdn.jsdelivr.net/npm/ http://cdnjs.cloudflare.com/; worker-src 'none';"
Content-Security-Policy "base-uri 'self'; connect-src 'self' https://*.gov.bc.ca https://*.amazoncognito.com https://*.cloudfront.net https://cdnjs.cloudflare.com/ https://cognito-idp.ca-central-1.amazonaws.com https://results-ques.netlify.app/api; default-src 'self'; font-src 'self'; frame-src 'self' https://*.gov.bc.ca; img-src 'self' http://www.w3.org/ https://cdnjs.cloudflare.com/ https://www.google.cn/maps/ http://*.google.com/ https://*.google.com; manifest-src 'self'; media-src 'self'; object-src 'none'; script-src 'unsafe-inline' 'report-sample' 'self' https://cdn.jsdelivr.net/npm/; style-src 'report-sample' 'self' https://cdn.jsdelivr.net/npm/ https://dq9dozspu8y40.cloudfront.net/; style-src-elem 'report-sample' 'self' https://cdn.jsdelivr.net/npm/ http://cdnjs.cloudflare.com/; worker-src 'none';"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't allow all of google.com. Is there something more specific to work with?

@DerekRoberts
Copy link
Member

Being replaced by #207.

@DerekRoberts DerekRoberts deleted the fix/openingCaddy branch January 11, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants