chore: addressing sonar issues

bcgov · Nov 5, 2024 · 4a1bbae · 4a1bbae
1 parent c062fdd
commit 4a1bbae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/backend/src/main/java/ca/bc/gov/restapi/results/postgres/endpoint/UserOpeningEndpoint.java b/backend/src/main/java/ca/bc/gov/restapi/results/postgres/endpoint/UserOpeningEndpoint.java
@@ -45,7 +45,7 @@ public ResponseEntity<List<MyRecentActionsRequestsDto>> getUserTrackedOpenings()
    * @return HTTP status code 201 if success, no response body.
    */
   @PostMapping("/{id}")
-  public ResponseEntity<Void> saveUserOpening(Long id) {
+  public ResponseEntity<Void> saveUserOpening(@PathVariable Long id) {
     userOpeningService.addUserFavoriteOpening(id);
     return ResponseEntity.status(HttpStatus.CREATED).build();
   }

diff --git a/backend/src/main/java/ca/bc/gov/restapi/results/postgres/service/UserOpeningService.java b/backend/src/main/java/ca/bc/gov/restapi/results/postgres/service/UserOpeningService.java
@@ -108,14 +108,13 @@ public List<Long> listUserFavoriteOpenings() {
 
   @Transactional
   public void addUserFavoriteOpening(Long openingId) {
-  log.info("Adding opening ID {} as favorite for user {}", openingId,
-      loggedUserService.getLoggedUserId());
-    openingRepository
-        .findById(openingId)
-        .orElseThrow(() -> {
-          log.info("Opening ID not found: {}", openingId);
-          return new OpeningNotFoundException();
-        });
+    log.info("Adding opening ID {} as favorite for user {}", openingId,
+        loggedUserService.getLoggedUserId());
+
+    if (openingRepository.findById(openingId).isEmpty()) {
+      log.info("Opening ID not found: {}", openingId);
+      throw new OpeningNotFoundException();
+    }
 
     log.info("Opening ID {} added as favorite for user {}", openingId,
         loggedUserService.getLoggedUserId());