Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix trivy workflow permissions #105

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

marcellmueller
Copy link
Contributor

@marcellmueller marcellmueller commented Dec 3, 2024

Trivy is failing on merge to main:

  Warning: Resource not accessible by integration
  Error: Resource not accessible by integration

Edit: @DerekRoberts figured it out, it was the permissions set for commitlint at the top of the file 🙃 I've moved them to the commitlint job so it shouldn't affect Trivy anymore.

@marcellmueller
Copy link
Contributor Author

@mishraomp Any thoughts on this? It's not failing in quickstart-openshift repo, maybe they are using PAT?

@mishraomp
Copy link
Collaborator

@mishraomp Any thoughts on this? It's not failing in quickstart-openshift repo, maybe they are using PAT?

I dont think we ever use PAT, @DerekRoberts thoughts?

@marcellmueller marcellmueller marked this pull request as ready for review December 4, 2024 02:13
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcellmueller marcellmueller merged commit 06f697c into main Dec 4, 2024
13 checks passed
@marcellmueller marcellmueller deleted the trivy-permissions branch December 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants