Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add MapBox to Cross Section page #212

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Conversation

lunamoonmoon
Copy link
Contributor

@lunamoonmoon lunamoonmoon commented Nov 22, 2024

Description

Added mapbox displaying wells to cross section page.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The cross section page has a test checking if it renders when user is logged in

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Screenshot 2024-11-22 at 3 51 21 PM


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@lunamoonmoon lunamoonmoon marked this pull request as ready for review November 22, 2024 23:54
@lunamoonmoon lunamoonmoon requested review from DerekRoberts and a team as code owners November 22, 2024 23:54
@raarielgrace raarielgrace linked an issue Nov 26, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@raarielgrace raarielgrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add more screenshots with the cross section tool in action? Or was this PR just to get the basic map up?

frontend/src/router.js Show resolved Hide resolved
frontend/src/crosssection/components/CrossMap.vue Outdated Show resolved Hide resolved
frontend/src/crosssection/views/CrossHome.vue Outdated Show resolved Hide resolved
@lunamoonmoon
Copy link
Contributor Author

lunamoonmoon commented Dec 24, 2024

@raarielgrace > Could you add more screenshots with the cross section tool in action? Or was this PR just to get the basic map up?

Not too much to show as this ticket is just for the map on the page :)
Screenshot 2024-12-24 at 1 23 27 PM

@lunamoonmoon lunamoonmoon merged commit 8cf8b22 into main Jan 2, 2025
19 of 20 checks passed
@lunamoonmoon lunamoonmoon deleted the 211-xtoolmap branch January 2, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[X-Section] Add the mapbox to the x-section tool page
2 participants