Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): Remove id from Well Attachment model that was not applied in a migrat… #209

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

fergmac
Copy link
Collaborator

@fergmac fergmac commented Nov 21, 2024

…ion.

Description

Rolled back migrations to remove the known previously unapplied migrations. Only applying the AquiferParameters private field migration.

Also including a "fake" migration to remove the WellAttachment ID field from the model. Django automagically adds an ID to a model. The Well Attachment model had one of these automagic ID's when an ID field was added to the model (I think just likely never cleaned up). The added id was never added to a migration file and therefore never applied. I have removed the Well Attachment ID field and faked a migration so that this change wont be picked up as a migration in future migrations.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@fergmac fergmac self-assigned this Nov 21, 2024
@fergmac fergmac requested review from DerekRoberts and a team as code owners November 21, 2024 18:34
@fergmac fergmac merged commit dd76cb1 into main Nov 21, 2024
20 of 22 checks passed
@fergmac fergmac deleted the chore/backend/migrations branch November 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant