Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): #2274 Private Toggle for Aquifer Parameters on Well Details Page #178

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

lunamoonmoon
Copy link
Contributor

@lunamoonmoon lunamoonmoon commented Nov 12, 2024

Description

Added private column and toggle to aquifer parameters table on well details page. Ran migration to add private to aquifer parameters table in database.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

When logged in with userRoles wells.edit
Screenshot 2024-11-12 at 10 15 35 AM

When not logged in
Screenshot 2024-11-12 at 9 41 21 AM


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@lunamoonmoon lunamoonmoon marked this pull request as ready for review November 12, 2024 18:42
@lunamoonmoon lunamoonmoon requested review from DerekRoberts and a team as code owners November 12, 2024 18:42
@fergmac fergmac requested review from fergmac and removed request for fergmac November 19, 2024 22:31
@lunamoonmoon lunamoonmoon merged commit d53e5a8 into main Nov 20, 2024
20 checks passed
@lunamoonmoon lunamoonmoon deleted the 2274-privatetoggle branch November 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option for private aquifer parameters to be entered and only viewable to internal users
2 participants