Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-1631): updating details api for legacy clients #1356

Merged
merged 28 commits into from
Dec 19, 2024
Merged

feat(FSADT1-1631): updating details api for legacy clients #1356

merged 28 commits into from
Dec 19, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Dec 9, 2024 •
edited by github-actions bot
Loading

Description

Changing the existing code to be more clean

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Current changelog

Features

  • FSADT1-1631: removing unused code (7a31863)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Current changelog

Features

  • fe:FSADT1-1574: CLIENT_VIEWER Client Summary Section - Front-End (#1335) (c030807)
  • FSADT1-1631: removing unused code (7a31863)

@github-actions GitHub Actions
Copy link
Contributor

Current changelog

Features

  • fe:FSADT1-1574: CLIENT_VIEWER Client Summary Section - Front-End (#1335) (c030807)
  • FSADT1-1631: removing unused code (7a31863)

@paulushcgcj
feat(FSADT1-1631): added context propagator for roles
0bc8600 
- Reused the MDC for role context propagator.
- Refactored the UserID filter
- Extracted the context propagator filter
@paulushcgcj
chore: small update on the DTO
8045989
@paulushcgcj
chore: added the role mdc constant
b146cf2
@paulushcgcj
feat(FSADT1-1631): updated principal util roles to set
bd23321 
- Changed to SET from LIST to account for unique values
@paulushcgcj
feat(FSADT1-1631): added client details obfuscator
eb7ba7c 
- This will obfuscate values based on roles and fields
@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 803f583 into main Dec 19, 2024
29 checks passed
@paulushcgcj paulushcgcj deleted the feat/FSADT1-1631 branch December 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia