Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FSADT1-1281): adding encryption to the connection #1341

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat(FSADT1-1281): adding encryption to the connection #1341

wants to merge 13 commits into from

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Dec 3, 2024 •
edited by github-actions bot
Loading

Description

As part of our Initial Security Risk assessment, one of the points raised was "Sensitive data exfiltration attack on the Postgres database". To handle that, we opened FSADT1-1281.

We need to enhance the security of our PostgreSQL database by implementing encryption measures. This includes adding encryption at rest for the database, enabling connection encryption to ensure secure data transmission, and implementing field-level encryption for sensitive data.

  • Connection Encryption:
    • Configure PostgreSQL to enforce SSL/TLS encryption for all client connections to the database.
    • Ensure that the SSL/TLS certificate is properly configured and valid.
  • Field Encryption:
    • Identify sensitive fields in the database schema that require encryption, such as Personally Identifiable Information (PII).
    • Implement field-level encryption for the identified sensitive fields, ensuring that data is encrypted before being stored in the database and decrypted when retrieved.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Manual tests (description below)
  • Updated existing tests

For test, a user can log into the database pod and check the encrypted columns without passing the key

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Current changelog

Features

@paulushcgcj
feat(FSADT1-1281): enabling pgcrypto on database
f23d6de
@paulushcgcj
chore: renaming test migration file
7783a91 
This is to make it easier for us to insert data before the encryption starts
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Current changelog

Features

@paulushcgcj paulushcgcj changed the title feat(FSADT1-1281): changing backup images feat(FSADT1-1281): adding encryption to the connection Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Current changelog

Features

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Current changelog

Features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia Awaiting requested review from mamartinezmejia mamartinezmejia will be requested when the pull request is marked ready for review mamartinezmejia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushcgcj @mamartinezmejia