test: adding test

backend/src/main/java/ca/bc/gov/app/converters/ForestClientObfuscate.java

@@ -17,7 +17,7 @@
 public class ForestClientObfuscate<T> extends JsonSerializer<T> {
 
   public static final String CLIENT_IDENTIFICATION = "clientIdentification";
-  private final List<String> obfuscableFields = List.of(CLIENT_IDENTIFICATION, "birthdate");
+  private final List<String> obfuscateFields = List.of(CLIENT_IDENTIFICATION, "birthdate");
 
   /**
    * Serializes the given value, obfuscating certain fields based on user roles.
@@ -63,7 +63,7 @@ public void serialize(
           clientIdTypeCode = rawValue.toString();
         }
 
-        if (obfuscableFields.contains(propName)) {
+        if (obfuscateFields.contains(propName)) {
           gen.writeString(obfuscate(propName, clientIdTypeCode, rawValue));
           continue;
         }

backend/src/test/java/ca/bc/gov/app/converters/ForestClientObfuscateTest.java

@@ -0,0 +1,102 @@
+package ca.bc.gov.app.converters;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+import ca.bc.gov.app.ApplicationConstant;
+import ca.bc.gov.app.dto.legacy.ForestClientDetailsDto;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
+import java.time.LocalDate;
+import java.util.List;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.slf4j.MDC;
+
+class ForestClientObfuscateTest {
+
+  private static final ObjectMapper mapper = new ObjectMapper();
+
+  @BeforeAll
+  public static void setUp() {
+    SimpleModule module = new SimpleModule();
+    module.setSerializerModifier(new ForestClientDetailsSerializerModifier());
+    mapper.registerModule(new JavaTimeModule());
+    mapper.registerModule(module);
+
+  }
+
+  @Test
+  void shouldObfuscateIdentification() throws Exception {
+    MDC.put(ApplicationConstant.MDC_USERROLES, ApplicationConstant.ROLE_VIEWER);
+    String json = mapper.writeValueAsString(getDto());
+    assertThat(json)
+        .contains("\"clientIdentification\":\"1***678\"")
+        .contains("\"birthdate\":\"1070-**-**\"");
+  }
+
+  @Test
+  void shouldObfuscateBCSC() throws Exception {
+    MDC.put(ApplicationConstant.MDC_USERROLES, ApplicationConstant.ROLE_VIEWER);
+    String json = mapper.writeValueAsString(getDto().withClientIdTypeCode("BCSC"));
+    assertThat(json)
+        .contains("\"clientIdentification\":\"BC Service card verified\"")
+        .contains("\"birthdate\":\"1070-**-**\"");
+  }
+
+  @Test
+  void shouldNotObfuscateSmallIds() throws Exception {
+    MDC.put(ApplicationConstant.MDC_USERROLES, ApplicationConstant.ROLE_VIEWER);
+    String json = mapper.writeValueAsString(getDto().withClientIdentification("1234"));
+    assertThat(json)
+        .contains("\"clientIdentification\":\"1234\"")
+        .contains("\"birthdate\":\"1070-**-**\"");
+  }
+
+  @Test
+  void shouldNotObfuscateForNonViewers() throws Exception {
+    MDC.put(ApplicationConstant.MDC_USERROLES, ApplicationConstant.ROLE_EDITOR);
+    String json = mapper.writeValueAsString(getDto());
+    assertThat(json)
+        .contains("\"clientIdentification\":\"12345678\"")
+        .contains("\"birthdate\":\"1070-12-13\"");
+  }
+
+  @Test
+  void shouldNotObfuscateEvenIfHasViewer() throws Exception {
+    MDC.put(ApplicationConstant.MDC_USERROLES, String.format("%s,%s", ApplicationConstant.ROLE_EDITOR, ApplicationConstant.ROLE_VIEWER));
+    String json = mapper.writeValueAsString(getDto());
+    assertThat(json)
+        .contains("\"clientIdentification\":\"12345678\"")
+        .contains("\"birthdate\":\"1070-12-13\"");
+  }
+
+  private ForestClientDetailsDto getDto() {
+    return new ForestClientDetailsDto(
+        "123456789",
+        "Wick",
+        "Johnathan",
+        null,
+        "ACT",
+        "Active",
+        "I",
+        "Individual",
+        "BCDL",
+        "BC Drivers License",
+        "12345678",
+        null,
+        null,
+        null,
+        null,
+        null,
+        null,
+        null,
+        null,
+        LocalDate.of(1070, 12, 13),
+        List.of(),
+        List.of(),
+        List.of()
+    );
+  }
+
+}