Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #82 allow search by user guid #83

Merged
merged 14 commits into from
Apr 30, 2024

Conversation

MCatherine1994
Copy link
Collaborator

@MCatherine1994 MCatherine1994 commented Apr 29, 2024

refs: #82

Please note: We cannot make the change directly to the existing api /bceid, the parameter change will impact FAM production. So instead, we created a new api route /businessBceid, once FAM finish the changes on FAM side, we'll work on the cleanup to remove the old /bceid api, #84

  • Search User by userId
    • Found
      Screen Shot 2024-04-29 at 3 08 22 PM
    • Not Found
      Screen Shot 2024-04-29 at 3 07 38 PM
  • Search User by userGuid
    • Found
      Screen Shot 2024-04-29 at 3 09 03 PM
    • Not Found
      Screen Shot 2024-04-29 at 3 10 12 PM

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@MCatherine1994
Copy link
Collaborator Author

The code duplicate is caused by that we can't make the change directly to the existing api path/bceid, the parameter change will impact FAM production. So instead, created a new api route /businessBceid, and once FAM finish the changes on FAM side, we'll work on the cleanup to remove the old /bceid api #84

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
58.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MCatherine1994 MCatherine1994 merged commit 7f28441 into main Apr 30, 2024
6 of 7 checks passed
@MCatherine1994 MCatherine1994 deleted the feat/82-allow-search-by-userguid branch April 30, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants