Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #132 (b)Temporary fix search IDIR user scenario broken by IDIM #133

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Nov 27, 2024

New temporary fix for production issue on IDIR looks up IDIR user scenario broken due to IDIM recent deployment.

  • Add new endpoint idir-account-detail and new method verifyIdirUserByIdimAccountDetail to call IDIM service by using GetAccountDetail webservice call.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review November 27, 2024 08:14
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
39.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the hard work!

@craigyu craigyu merged commit 040e10e into main Nov 27, 2024
8 of 10 checks passed
@craigyu craigyu deleted the fix/132b-verify-idir-using-get-account-details branch November 27, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants