Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Guidance and Contact Us pages #203

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Conversation

ccallendar
Copy link
Contributor

@ccallendar ccallendar commented Jul 30, 2024

Description

Added new Guidance and Contact Us pages, and fixed up the Footer and banner images.

Fixes #191

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • End to end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ccallendar ccallendar force-pushed the feat/guidance-contact-us-pages branch from cbadbc3 to 4aaa9c8 Compare July 30, 2024 20:17
@mishraomp
Copy link
Contributor

not sure why only safari is failing e2e with Error: expect.toBeVisible: Error: strict mode violation: getByText('12398') resolved to 2 elements:

@ccallendar , may be we add the first check rather than removing safari, thoughts?
https://playwright.dev/docs/api/class-locator#locator-first

Copy link

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishraomp mishraomp merged commit 0460a83 into main Jul 30, 2024
18 checks passed
@mishraomp mishraomp deleted the feat/guidance-contact-us-pages branch July 30, 2024 22:16
@ccallendar
Copy link
Contributor Author

ccallendar commented Jul 31, 2024

Thanks @mishraomp - there was a weird thing happening with the new document links where on test one of those document names included that number, and so it failed. Not sure why it didn't fail on all browsers!
I keep forgetting that Playwright by default does partial matches, where as Testing Library by default does exact matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guidance and Contact Us pages
2 participants