Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Site Risk Classification Report #711

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Update Site Risk Classification Report #711

merged 1 commit into from
Jun 19, 2024

Conversation

bolny
Copy link
Contributor

@bolny bolny commented Jun 18, 2024

Change the checkbox for exposure pathways in the Risk Classification Report to use a radio select instead of a checkbox select. Reasoning: We expect exactly one answer.

Fixes # SRS-267

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I have uploaded this form and validated that it now uses a radio input.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

- Change the checkbox for exposure pathways to use a radio select instead of a checkbox select. Reasoning: We expect exactly one answer.
@bolny bolny requested review from nikhila-aot and midhun-aot June 18, 2024 22:42
@bolny bolny self-assigned this Jun 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nikhila-aot nikhila-aot merged commit 314523e into dev Jun 19, 2024
10 checks passed
@nikhila-aot nikhila-aot deleted the feat/SRS-267 branch June 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants