Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove limits (cpu and memory) #842

Open
wants to merge 2 commits into
base: release/0.6.12
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions charts/app/templates/backend/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ spec:
- name: FLYWAY_LOCATIONS
value: "{{- if eq .Release.Namespace "c1c7ed-dev" -}}{{ .Values.global.secrets.flywayLocations.dev }}{{- else if eq .Release.Namespace "c1c7ed-test" -}}{{ .Values.global.secrets.flywayLocations.test }}{{- else if eq .Release.Namespace "c1c7ed-prod" -}}{{ .Values.global.secrets.flywayLocations.prod }}{{- else -}}filesystem:./flyway/sql{{- end }}"
resources:
limits:
cpu: 200m
memory: 200Mi
requests:
cpu: 50m
memory: 100Mi
Expand Down Expand Up @@ -93,9 +90,6 @@ spec:
periodSeconds: 30
timeoutSeconds: 5
resources: # this is optional
limits:
cpu: 450m
memory: 150Mi
requests:
cpu: 50m
memory: 75Mi
Expand Down
3 changes: 0 additions & 3 deletions charts/app/templates/frontend/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ spec:
periodSeconds: 30
timeoutSeconds: 5
resources:
limits:
cpu: 100m
memory: 150Mi
requests:
cpu: 30m
memory: 50Mi
Expand Down
4 changes: 0 additions & 4 deletions charts/app/templates/webeoc/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ spec:
periodSeconds: 30
timeoutSeconds: 5
resources: # this is optional
limits:
ephemeral-storage: "25Mi"
cpu: 80m
memory: 150Mi
requests:
ephemeral-storage: "15Mi"
cpu: 40m
Expand Down
39 changes: 0 additions & 39 deletions charts/app/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ backend:
- prod/api-2
#-- resources specific to vault initContainer. it is optional and is an object.
resources:
limits:
cpu: 50m
memory: 50Mi
requests:
cpu: 50m
memory: 25Mi
Expand Down Expand Up @@ -180,16 +177,10 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 25m
memory: 256Mi
limits:
cpu: 100m
memory: 512Mi
replicaCertCopy:
requests:
cpu: 1m
memory: 32Mi
limits:
cpu: 50m
memory: 64Mi

pgBackRest:
enabled: false
Expand All @@ -210,16 +201,10 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 1m
memory: 64Mi
limits:
cpu: 50m
memory: 128Mi
sidecars:
requests:
cpu: 1m
memory: 64Mi
limits:
cpu: 50m
memory: 128Mi

patroni:
postgresql:
Expand All @@ -238,9 +223,6 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 1m
memory: 64Mi
limits:
cpu: 50m
memory: 128Mi

# Postgres Cluster resource values:
pgmonitor:
Expand All @@ -250,9 +232,6 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 1m
memory: 64Mi
limits:
cpu: 50m
memory: 128Mi

bitnami-pg:
enabled: true
Expand Down Expand Up @@ -294,9 +273,6 @@ bitnami-pg:
requests:
cpu: 100m
memory: 250Mi
limits:
cpu: 200m
memory: 500Mi

backup:
enabled: false # save quota in dev environment, see gha for override
Expand Down Expand Up @@ -324,9 +300,6 @@ backup:
failedHistoryLimit: 2 # "The number of failed jobs that will be retained"
backoffLimit: 0 # "The number of attempts to try for a successful job outcome"
resources:
limits:
cpu: 150m
memory: 256Mi
requests:
cpu: 10m
memory: 128Mi
Expand All @@ -339,9 +312,6 @@ nats:
requests:
cpu: 100m
memory: 100Mi
limits:
cpu: 200m
memory: 400Mi
jetstream:
enabled: true
fileStore:
Expand All @@ -366,9 +336,6 @@ nats:
requests:
cpu: 100m
memory: 100Mi
limits:
cpu: 200m
memory: 400Mi

#-- WebEOC Container
webeoc:
Expand Down Expand Up @@ -416,9 +383,6 @@ metabase:
port: 80
targetPort: 3000
resources:
limits:
cpu: 750m
memory: 1250Mi
requests:
cpu: 150m
memory: 500Mi
Expand Down Expand Up @@ -472,7 +436,4 @@ metabase-pg:
requests:
cpu: 100m
memory: 250Mi
limits:
cpu: 200m
memory: 500Mi
#-- End Metabase Values
5 changes: 0 additions & 5 deletions database/openshift.deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ objects:
requests:
storage: ${DB_PVC_SIZE}
cpu: "50m"
limits:
cpu: "100m"
storageClassName: netapp-file-standard
- kind: ImageStream
apiVersion: v1
Expand Down Expand Up @@ -168,9 +166,6 @@ objects:
requests:
cpu: ${CPU_REQUEST}
memory: ${MEMORY_REQUEST}
limits:
cpu: ${CPU_LIMIT}
memory: ${MEMORY_LIMIT}
readinessProbe:
exec:
command:
Expand Down
1 change: 1 addition & 0 deletions webeoc/src/publishers/actions-taken-publisher.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export class ActionsTakenPublisherService {
private async initializeNATS() {
const nc = await connect({
servers: [process.env.NATS_HOST],
waitOnFirstConnect: true,
});
this.jsClient = nc.jetstream();
}
Expand Down
1 change: 1 addition & 0 deletions webeoc/src/publishers/complaints-publisher.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class ComplaintsPublisherService {
private async initializeNATS() {
const nc = await connect({
servers: [process.env.NATS_HOST],
waitOnFirstConnect: true,
});
this.jsClient = nc.jetstream();
}
Expand Down
2 changes: 1 addition & 1 deletion webeoc/src/subscribers/actions-taken-subscriber.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class ActionsTakenSubscriberService implements OnModuleInit {

async onModuleInit() {
try {
this.natsConnection = await connect({ servers: process.env.NATS_HOST });
this.natsConnection = await connect({ servers: process.env.NATS_HOST, waitOnFirstConnect: true });
this.jsm = await this.natsConnection.jetstreamManager();
await this.setupStream();
await this.subscribeToTopics();
Expand Down
2 changes: 1 addition & 1 deletion webeoc/src/subscribers/complaints-subscriber.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class ComplaintsSubscriberService implements OnModuleInit {

async onModuleInit() {
try {
this.natsConnection = await connect({ servers: process.env.NATS_HOST });
this.natsConnection = await connect({ servers: process.env.NATS_HOST, waitOnFirstConnect: true });
this.jsm = await this.natsConnection.jetstreamManager();
await this.setupStream();
await this.subscribeToTopics();
Expand Down
Loading