Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CE-749 Display message to user to remove filters when no complaints are found #716

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

joshgamache
Copy link
Contributor

@joshgamache joshgamache commented Oct 18, 2024

Addresses CE-749. Adds information to adjust filters when no complaints return.

Changes 🚧

  • Add message to filtered list display.
  • Change message in map display.

How Has This Been Tested? 🔬

  • Manual testing, matching replication procedure from issue report.

To test 🔬

  1. Run a local instance of the application, log in.
  2. On the complaints list page, add filters until no items return.
    • A message should display in the list view: "No complaints found using your current filters. Remove or change your filters to see complaints.".
  3. On the complaints map page, add filters until no items return.
    • A message should display in the alert box: "No complaints found using your current filters. Remove or change your filters to see complaints.".

Checklist 📃

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@joshgamache joshgamache self-assigned this Oct 18, 2024
@afwilcox afwilcox changed the base branch from release/lions-mane-jellyfish to release/noble-sea-lemon October 21, 2024 17:23
@joshgamache joshgamache force-pushed the chore/CE-749-no-complaints-message branch from 6849806 to 1c77518 Compare October 22, 2024 16:37
@joshgamache joshgamache marked this pull request as ready for review October 22, 2024 17:00
@joshgamache joshgamache force-pushed the chore/CE-749-no-complaints-message branch from 1c77518 to 9e5e400 Compare October 25, 2024 14:14
Copy link

@joshgamache joshgamache requested a review from afwilcox October 25, 2024 14:16
@afwilcox afwilcox merged commit 133fb42 into release/noble-sea-lemon Oct 25, 2024
15 checks passed
@afwilcox afwilcox deleted the chore/CE-749-no-complaints-message branch October 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants