Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE-909 Animal outcome drug forms reorder unexpectedly #713

Merged

Conversation

joshgamache
Copy link
Contributor

@joshgamache joshgamache commented Oct 17, 2024

Addresses CE-909. Addresses issue where data entered into one animal outcome drug field would swap around to other drugs.

Changes 🚧

  • Drug items now use an ordering function to ensure consistent order, and therefore entries.

How Has This Been Tested? 🔬

  • Manual testing, matching replication procedure from issue report.

To test 🔬

  1. Run a local instance of the application, log in and create a new issue.
  2. Under 'Outcome by Animal', click 'Add animal'.
  3. In animal outcome form, click 'Add drug' multiple times.
  4. In the first record, enter information in the fields. Information entered should stay in that record. Information entered into other records should stay in their respective record.

Checklist 📃

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Addresses #issue_number. brief_description_of_change


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a data entry perspective, but it looks like the order is messed up when you press save.

For example if I enter two drugs at once, they are switched around when I press save, however if I enter 1, press save, then add a second they appear in the correct order.

@afwilcox afwilcox changed the base branch from release/lions-mane-jellyfish to release/noble-sea-lemon October 21, 2024 17:14
@joshgamache joshgamache force-pushed the fix/CE-909-drug-field-entry-inconsistency branch from af31cb1 to 0722219 Compare October 22, 2024 21:33
Copy link

@joshgamache
Copy link
Contributor Author

Looks good from a data entry perspective, but it looks like the order is messed up when you press save.

For example if I enter two drugs at once, they are switched around when I press save, however if I enter 1, press save, then add a second they appear in the correct order.

@afwilcox Addressed the reordering after save with commit 0722219

@joshgamache joshgamache requested a review from afwilcox October 22, 2024 21:36
@afwilcox afwilcox merged commit 908e248 into release/noble-sea-lemon Oct 23, 2024
15 checks passed
@afwilcox afwilcox deleted the fix/CE-909-drug-field-entry-inconsistency branch October 23, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants