Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CE-590 standardized on actor guid #706

Merged
merged 33 commits into from
Oct 21, 2024
Merged

chore: CE-590 standardized on actor guid #706

merged 33 commits into from
Oct 21, 2024

Conversation

Scarlett-Truong
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong commented Oct 16, 2024 •
edited by github-actions bot
Loading

Description

Changing any officers field in outcome report (both COS & CEEB) to use auth_user_guid instead of person_guid and officer_guid

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test every fields that has officers in it to work as the same as before in the frontend, including:
  1. Modal assign officer in complaint head
  2. Filter of officer in complaints' table view
  3. COS: assessment, prevent and education, equipment (set and removed), animal outcome (drugs and the outcome), note, file review
  4. CEEB: decision
  • Check table action in database in case-management, column actor_guid to save the correct auth_user_guid

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments

There's a PR in case-management INCLUDED, only for updating the existing actor_guid in prod to use auth_user_guid

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

gregorylavery and others added 30 commits October 3, 2024 15:26
@gregorylavery @barrfalk
@dk-bcps @Scarlett-Truong @marqueone-ps @jeznorth @renovate @afwilcox
fix: Ce 478 (#685)
5e72328 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: dmitri-korin-bcps <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: jeznorth <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
Co-authored-by: Scarlett <[email protected]>
@nayr974
chore(CE-1118): CE-1118 Add Ryan as officer for test and prod (#689)
da3a597
@jon-funk
chore(CE-1118): add Jon as officer to test and prod data (#688)
da5087f
@mikevespi @barrfalk
chore: CE 1119 add Mike to users (#690)
94f9304 
Co-authored-by: barrfalk <[email protected]>
@afwilcox
feat: CE-750 Display Current Date in Filter when only one date select…
043c1e7 
…ed (#697)
@nayr974 @afwilcox
chore(CE-535): Refactor ValidationInput and ValidationSelect to use C…
343bf71 
…ompInput and CompSelect (#696)

Co-authored-by: afwilcox <[email protected]>
@afwilcox
fix: CE-1050 Makes it so cypress tests work on empty case management …
91c1b3b 
…database (#695)
@mishraomp @afwilcox
chore(ci): Dockerfile updates (#693)
e2b7101 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@nayr974
fix: Config.js error while developing locally (#699)
b4f59cd
@afwilcox
fix: Clear CDOGS templates with every run (#700)
70f8b02
@gregorylavery @afwilcox
fix: Ce 1127 (#694)
b8aae06 
Co-authored-by: afwilcox <[email protected]>
@renovate @afwilcox
chore(deps): update dependency @types/jest to v29.5.13 (#704)
fde5a56 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
@dk-bcps
feat: CE-550- modal-improvements-V2 (#703)
a788f68
@Scarlett-Truong
chore: standardize on actor_guid
b027dd7
@Scarlett-Truong
Merge branch 'release/lions-mane-jellyfish' into chore/CE-590
1df4cb0
@afwilcox
feat: Method Complaint Received Cypress Tests (#701)
46d6c1d
@Scarlett-Truong
Merge branch 'release/lions-mane-jellyfish' into chore/CE-590
7959ee5
@Scarlett-Truong
fix default assigned officer in ceeb decision
9863d60
@nayr974
fix: CE 1124 (#705)
d86e33e
@Scarlett-Truong
fix equipment default officer
a056848
@Scarlett-Truong
Merge branch 'release/lions-mane-jellyfish' into chore/CE-590
f6a2606
@Scarlett-Truong
merge branch
4ae9271
@dk-bcps @afwilcox
fix: CE-1143-apply-scroll-bar-to-assign-modal (#710)
24a3c76 
Co-authored-by: afwilcox <[email protected]>
@jon-funk @barrfalk @afwilcox
fix: CE-917 enable autoscaling for test (#702)
02d58eb 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@jon-funk @afwilcox
fix: CE-1078 persist secret content changes between rollouts (#698)
9df80c5 
Co-authored-by: afwilcox <[email protected]>
@Scarlett-Truong
move file location
c59fc24
@mikevespi @afwilcox
feat: CE-1045 add action taken filter for ceeb (#708)
20d34a3 
Co-authored-by: afwilcox <[email protected]>
@nayr974
fix: CE 1124 (#711)
a338648
@Scarlett-Truong
refactor 1: officer list by agency
b06b11c
@Scarlett-Truong
solve conflict
ea53aef
@afwilcox afwilcox changed the base branch from release/lions-mane-jellyfish to release/noble-sea-lemon October 21, 2024 17:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
32.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@afwilcox afwilcox added the case_management_2 https://dc0a4a-compenf-dev-2-backend.apps.emerald.devops.gov.bc.ca/graphql label Oct 21, 2024
@afwilcox afwilcox merged commit 5e692c6 into release/noble-sea-lemon Oct 21, 2024
14 of 15 checks passed
@afwilcox afwilcox deleted the chore/CE-590 branch October 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwilcox afwilcox afwilcox approved these changes

Assignees
No one assigned
Labels
case_management_2 https://dc0a4a-compenf-dev-2-backend.apps.emerald.devops.gov.bc.ca/graphql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Scarlett-Truong @afwilcox @gregorylavery @nayr974 @jon-funk @mikevespi @mishraomp @dk-bcps