Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE 1124 #705

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix: CE 1124 #705

merged 4 commits into from
Oct 16, 2024

Conversation

nayr974
Copy link
Collaborator

@nayr974 nayr974 commented Oct 15, 2024

Description

Changes the way the appropriate git tag is selected. Instead of using git describe --tags to select the tag, which is only returning the first tag it uses git tag --merged which should select all tags that have been merged into the current branch. It's not clear exactly why git describe isn't working, but it has different logic to select the best or closest tag based on the branch history, not necessarily the newest tag.

References:
https://git-scm.com/docs/git-describe
https://stackoverflow.com/questions/67190989/when-and-why-exactly-does-git-describe-not-show-the-latest-tag

image

Question:

  • How are branches merged into main?

How Has This Been Tested?

TBD

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@nayr974 nayr974 added the pipeline change Change that updates the pipeline label Oct 15, 2024
@nayr974 nayr974 requested review from jon-funk and barrfalk October 15, 2024 20:59
@nayr974 nayr974 changed the base branch from main to release/lions-mane-jellyfish October 15, 2024 21:00
@nayr974 nayr974 closed this Oct 15, 2024
@nayr974 nayr974 reopened this Oct 15, 2024
@nayr974 nayr974 changed the title CE 1124 fix: CE 1124 Oct 15, 2024
Copy link

@barrfalk barrfalk merged commit d86e33e into release/lions-mane-jellyfish Oct 16, 2024
15 checks passed
@barrfalk barrfalk deleted the CE-1124 branch October 16, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline change Change that updates the pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants