Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/CE-49 - Date Range Filter not picking up end boundary dates #156

Merged
merged 11 commits into from
Oct 16, 2023
Merged

bug/CE-49 - Date Range Filter not picking up end boundary dates #156

merged 11 commits into from
Oct 16, 2023

Conversation

barrfalk
Copy link
Contributor

@barrfalk barrfalk commented Oct 13, 2023 •
edited by github-actions bot
Loading

Description

Date Range Filter not picking up end boundary dates

Add ability for users to manually enter in date ranges.

Fixes # (issue)

How Has This Been Tested?

  • Verified that manually entering in a date range of the format {yyyy-mm-dd} - {yyyy-mm-dd} correctly applies the filter
  • Verified that manually entering in a date range of not in the format {yyyy-mm-dd} - {yyyy-mm-dd} will not break

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@barrfalk barrfalk temporarily deployed to dev October 13, 2023 03:54 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 03:54 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 03:54 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 03:54 — with GitHub Actions Inactive
@barrfalk barrfalk marked this pull request as ready for review October 13, 2023 04:05
@barrfalk barrfalk enabled auto-merge October 13, 2023 04:05
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 04:09 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 04:09 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 04:09 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 04:09 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 15:35 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 15:35 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 15:35 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 15:35 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 20:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 20:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 20:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 20:22 — with GitHub Actions Inactive
@barrfalk barrfalk marked this pull request as draft October 13, 2023 23:47
auto-merge was automatically disabled October 13, 2023 23:47

Pull request was converted to draft

@barrfalk barrfalk temporarily deployed to dev October 13, 2023 23:57 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 13, 2023 23:57 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 14, 2023 00:33 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 14, 2023 00:33 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 14, 2023 00:33 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 14, 2023 00:33 — with GitHub Actions Inactive
@barrfalk barrfalk marked this pull request as ready for review October 14, 2023 01:32
@barrfalk barrfalk enabled auto-merge October 16, 2023 03:06
@barrfalk barrfalk temporarily deployed to dev October 16, 2023 16:24 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 16, 2023 16:24 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 16, 2023 16:24 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 16, 2023 16:24 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@afwilcox afwilcox temporarily deployed to dev October 16, 2023 18:47 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 18:47 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 18:48 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:26 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:26 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:26 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:44 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:44 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:44 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev October 16, 2023 19:44 — with GitHub Actions Inactive
@barrfalk barrfalk added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit cda2c13 Oct 16, 2023
@barrfalk barrfalk deleted the bug/CE-49 branch October 16, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwilcox afwilcox afwilcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrfalk @afwilcox