Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPENF-428-Cypress Tests #143

Merged
merged 13 commits into from
Oct 3, 2023
Merged

COMPENF-428-Cypress Tests #143

merged 13 commits into from
Oct 3, 2023

Conversation

barrfalk
Copy link
Contributor

@barrfalk barrfalk commented Oct 1, 2023

Description

Cleaned up cypress tests.

Added cypress tests for complaints on map (COMPENF-428 and COMPENF-429)

Fixes # (issue)

How Has This Been Tested?

  • Added tests to verify filters remain intact when switching between list and map view. Verified passed.
  • Added tests to verify filters can be used on map screen. Verified passed.
  • Verified new commands didn't break existing cypress tests.
  • Added test to verify default filters exist, and manually verified that this works.
  • Added tests to verify popup appears when clicking markers, and manually verified that this works.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 20:17 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 20:17 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 20:17 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 20:17 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:40 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:40 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:40 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:40 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:48 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:48 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:48 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:52 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 21:52 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 00:25 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 00:25 — with GitHub Actions Inactive
Added better tests
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:34 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:34 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:34 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:34 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:45 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:51 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:51 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:51 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 15:51 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.8% 17.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@barrfalk barrfalk temporarily deployed to dev October 2, 2023 16:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 16:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 16:22 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 2, 2023 16:22 — with GitHub Actions Inactive
@barrfalk barrfalk marked this pull request as ready for review October 2, 2023 17:01
@barrfalk barrfalk enabled auto-merge October 2, 2023 17:02
@barrfalk barrfalk added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 6adbb02 Oct 3, 2023
@barrfalk barrfalk deleted the feature/COMPENF-428 branch October 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants