Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for sticky header with expanded filters #141

Merged
merged 6 commits into from
Oct 1, 2023
Merged

bugfix for sticky header with expanded filters #141

merged 6 commits into from
Oct 1, 2023

Conversation

afwilcox
Copy link
Collaborator

@afwilcox afwilcox commented Sep 29, 2023 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Filter Button works regardless of where on page scroll is

Checklist

  • New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@afwilcox afwilcox temporarily deployed to dev September 29, 2023 19:53 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 19:53 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 19:53 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 19:53 — with GitHub Actions Inactive
@afwilcox afwilcox marked this pull request as ready for review September 29, 2023 20:43
@afwilcox afwilcox enabled auto-merge September 29, 2023 20:43
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 21:38 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 21:38 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 21:38 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 21:38 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 22:49 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 22:49 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 22:49 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 22:49 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:00 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:00 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:00 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:00 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:52 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:52 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:52 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 29, 2023 23:52 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 30, 2023 00:30 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 30, 2023 00:30 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 30, 2023 00:30 — with GitHub Actions Inactive
@afwilcox afwilcox temporarily deployed to dev September 30, 2023 00:30 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:41 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:41 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:41 — with GitHub Actions Inactive
@barrfalk barrfalk temporarily deployed to dev October 1, 2023 15:41 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.7% 8.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@afwilcox afwilcox added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit c81295a Oct 1, 2023
12 of 15 checks passed
@afwilcox afwilcox deleted the bug/compenf-951 branch October 1, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrfalk barrfalk barrfalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afwilcox @barrfalk