Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable_won_emails #1663

Merged
merged 5 commits into from
Jan 11, 2025
Merged

Conversation

kzdev420
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzdev420 kzdev420 reopened this Jan 11, 2025
@severinbeauvais severinbeauvais self-requested a review January 11, 2025 00:19
@@ -1531,7 +1531,7 @@ zipp = "^3.8.1"
type = "git"
url = "https://github.com/bcgov/namex.git"
reference = "HEAD"
resolved_reference = "63b06cfb82228002e89e7f43343c117cde4a0ae5"
resolved_reference = "0a7ac33807f801b73f3d08171213e1fccb343a38"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this came from here:

Screenshot 2025-01-10 at 4 20 32 PM

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated changes look good to me.

@severinbeauvais
Copy link
Collaborator

Steven says OK to merge.

@severinbeauvais severinbeauvais merged commit e650f96 into bcgov:release-1.2.21 Jan 11, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants