24849 change request search back to search functionality #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPortman
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag and
flutistar
as code owners
EPortman
force-pushed
the
24849_change_request_search_back_to_search_functioality
branch
from
47bd3b9 to
0953943
Compare
|
rarmitag
approved these changes
Dec 11, 2024
EPortman
deleted the
24849_change_request_search_back_to_search_functioality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://app.zenhub.com/workspaces/names-team-board-new-655554cbddd49510027dad2e/issues/gh/bcgov/entity/24849
Description of changes:
In my previous PR, #1629, I mistakenly took away the functionality of being able to search and limit the number of requests returned - effectively changing the search into an exact match.
This PR reverts that mistake allowing it to function as a search once again.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).