23382 and 24193: updated codes #1612
Conversation
- regrouped mapping items for consistency
- added BECC (x2) - added CNV codes for continued in businesses - added comments
- spelled out "BC Limited Company" and others - added BECC and other missing CNV codes - added whitespace and comments
severinbeauvais
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
|
| CONTINUE_IN = 'C' # Continued In BC Limited Company | ||
| BEN_CONTINUE_IN = 'CBEN' # Continued In BC Benefit Company | ||
| CCC_CONTINUE_IN = 'CCC' # Continued In BC Community Contribution Company | ||
| ULC_CONTINUE_IN = 'CUL' # Continued In BC Unlimited Liability Company |
There was a problem hiding this comment.
I renamed these to be consistent with the enum used by the Entity UIs (and Namerequest UI).
Basically, instead of yet another standalone enum, these now match this:
https://github.com/bcgov/bcrs-shared-components/blob/main/src/modules/corp-type-module/corp-type-module.ts
| ('BECR', EntityTypes.CORPORATION.value, RequestAction.RESUBMIT.value), | ||
| ('ULCB', EntityTypes.CORPORATION.value, RequestAction.CNV.value, True), # Unlimited Liability Company -> BC Limited Company | ||
| ('ULCB', EntityTypes.CORPORATION.value, RequestAction.RESUBMIT.value), | ||
|
|
There was a problem hiding this comment.
I moved all CORPORATION items together, and same for others below.
| ('BECV', EntityTypes.BEN_CONTINUE_IN.value, RequestAction.CNV.value, True), # continued in BC Limited Company -> continued in Benefit Company | ||
| ('BECV', EntityTypes.BEN_CONTINUE_IN.value, RequestAction.RESUBMIT.value), | ||
| ('ULBE', EntityTypes.BEN_CONTINUE_IN.value, RequestAction.CNV.value, True), # continued in Unlimited Liability Company -> continued in Benefit Company | ||
| ('ULBE', EntityTypes.BEN_CONTINUE_IN.value, RequestAction.RESUBMIT.value), |
There was a problem hiding this comment.
This is now the complete list of all applicable NR types for all business types.
You can compare this with:
https://github.com/bcgov/bcrs-shared-components/blob/main/src/enums/name-request-codes.ts
| ('RCR', 'BC', 'BC Limited Company', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None), | ||
| ('BECR', 'BC', 'BC Limited Company', 'Conversion from Benefit Company ', 'lear', 'alteration', None, "{'filing': {'header': {'name': {entitiesFilingName} }, '{entitiesFilingName}': {'nameRequest': {'nrNumber': '{nrNumber}', 'legalName': '{legalName}', 'legalType': '{legalType}'}}}}"), | ||
| ('ULCB', 'BC', 'BC Limited Company', 'Conversion from ULC', 'lear', 'alteration', None, "{'filing': {'header': {'name': {entitiesFilingName} }, '{entitiesFilingName}': {'nameRequest': {'nrNumber': '{nrNumber}', 'legalName': '{legalName}', 'legalType': '{legalType}'}}}}"), | ||
|
|
There was a problem hiding this comment.
I moved all "BC" items together, and same for others below.
| ('RCC', 'CCC', 'Continued In CCC', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None), | ||
| ('RUL', 'CUL', 'Continued In ULC', 'Restoration', 'static', None, 'https://www2.gov.bc.ca/gov/content/employment-business/business/managing-a-business/permits-licences/businesses-incorporated-companies/forms-corporate-registry#information-packages', None), | ||
| ('BERE', 'CBEN', 'Continued in Benefit Company', 'Restoration', 'lear', None, None, None), | ||
|
|
There was a problem hiding this comment.
This lookup table (which is used by an endpoint only, I believe), now contains all possible [NR type, entity type] tuples, similarly to the other table and to this:
https://github.com/bcgov/bcrs-shared-components/blob/main/src/enums/name-request-codes.ts
Other notes:
|
|
@eve-git @stevenc987 , could you please review this PR and merge it if acceptable? Thanks! |
Issue #: bcgov/entity#23382 and bcgov/entity#24193
Description of changes:
- renamed enums for consistency with LEAR
- regrouped mapping items for consistency
- moved some codes together
- added BECC (x2)
- added CNV codes for continued in businesses
- added comments
- moved some codes together
- spelled out "BC Limited Company" and others
- added BECC and other missing CNV codes
- added whitespace and comments
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).