Pipd 945 show pop up once the wizard is complete #619
Conversation
…-945-Show-pop-up-once-the-wizard-is-complete
…tps://github.com/bcgov/moh-pidp into Pipd-945-Show-pop-up-once-the-wizard-is-complete
…-945-Show-pop-up-once-the-wizard-is-complete
AdityaMantripragada
added
Ready For Review
AdityaMantripragada
requested review from
james-hollinger,
Paahn and
kakarlavinodkumar
| window.scrollTo({ top: 0 }); | ||
| setTimeout(() => { | ||
| resolve(); | ||
| }, 300); |
There was a problem hiding this comment.
I think we can define the timeout value in the constants.
There was a problem hiding this comment.
This function can be replaced as it exists as a service
| @@ -68,12 +68,25 @@ export class CollegeLicenceInformationPage implements OnInit { | |||
| this.title = this.route.snapshot.data.title; | |||
| } | |||
|
|
|||
| public scrollToTop(): Promise<void> { | |||
There was a problem hiding this comment.
Use scrollTopWithDelay from UtilsService instead
|
The pop up doesnt open when the first time user selects |
I initially thought it was expected behavior, as the pop-up might only be relevant for users with college licenses. If you think it should appear for all users, even those selecting ‘None,’ I’ll explore updating this flow. What do you suggest? |
AdityaMantripragada
added
DO NOT MERGE
…tps://github.com/bcgov/moh-pidp into Pipd-945-Show-pop-up-once-the-wizard-is-complete
|
AdityaMantripragada
added
Ready For Review
…tps://github.com/bcgov/moh-pidp into Pipd-945-Show-pop-up-once-the-wizard-is-complete
…tps://github.com/bcgov/moh-pidp into Pipd-945-Show-pop-up-once-the-wizard-is-complete
|
No description provided.