Skip to content

Merge branch 'PIDP-1094-User-feedback-button-on-PIDP' of https://gith… #2537

Merge branch 'PIDP-1094-User-feedback-button-on-PIDP' of https://gith…

Merge branch 'PIDP-1094-User-feedback-button-on-PIDP' of https://gith… #2537

Triggered via push January 8, 2025 00:36
Status Success
Total duration 5m 14s
Artifacts

pr-build.yaml

on: push
get-pr-number
7s
get-pr-number
unit-test-plr-intake
29s
unit-test-plr-intake
unit-test-webapi
42s
unit-test-webapi
Frontend Build & Push
4m 4s
Frontend Build & Push
Frontend Yarn Lint
1m 19s
Frontend Yarn Lint
PLR Intake Backend Build & Push
37s
PLR Intake Backend Build & Push
WebAPI Backend Build & Push
1m 3s
WebAPI Backend Build & Push
helm-deployment
40s
helm-deployment
Fit to window
Zoom out
Zoom in

Annotations

19 warnings
get-pr-number
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
unit-test-plr-intake
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
unit-test-webapi
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
unit-test-webapi: backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L38
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
unit-test-webapi: backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L44
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
unit-test-webapi: backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Use 'string.IndexOf(char)' instead of 'string.IndexOf(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866)
unit-test-webapi: backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
unit-test-webapi: backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
unit-test-webapi: backend/webapi/Features/Discovery/Discovery.cs#L61
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
unit-test-webapi: backend/webapi/Features/Discovery/Discovery.cs#L61
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
unit-test-webapi: backend/webapi/Features/EndorsementRequests/EmailSearch.cs#L33
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
unit-test-webapi: backend/webapi/Features/EndorsementRequests/EmailSearch.cs#L33
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
unit-test-webapi: backend/webapi/Features/EndorsementRequests/EmailSearch.cs#L33
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
PLR Intake Backend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Frontend Yarn Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
WebAPI Backend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Frontend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
helm-deployment
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
helm-deployment
Multiple files were found for oc that matched the current OS and architecture: openshift-client-linux-4.17.11.tar.gz, openshift-client-linux-amd64-rhel8-4.17.11.tar.gz, openshift-client-linux-amd64-rhel9-4.17.11.tar.gz, openshift-client-linux-arm64-4.17.11.tar.gz, openshift-client-linux-arm64-rhel8-4.17.11.tar.gz, openshift-client-linux-arm64-rhel9-4.17.11.tar.gz, openshift-client-linux-ppc64le-4.17.11.tar.gz, openshift-client-linux-ppc64le-rhel8-4.17.11.tar.gz, openshift-client-linux-ppc64le-rhel9-4.17.11.tar.gz, openshift-client-linux-s390x-rhel8-4.17.11.tar.gz, openshift-client-linux-s390x-rhel9-4.17.11.tar.gz. Selecting the first one.