unit tests fixed. #2502
pr-build.yaml
on: push
get-pr-number
7s
Frontend Yarn Lint
1m 16s
PLR Intake Backend Build & Push
38s
WebAPI Backend Build & Push
1m 7s
helm-deployment
41s
Annotations
7 errors and 16 warnings
Frontend Yarn Lint:
workspace/apps/pidp/src/app/shared/components/feedback-form/feedback-form.dialog.spec.ts#L13
'formUtilsServiceSpy' is assigned a value but never used
|
Frontend Yarn Lint:
workspace/apps/pidp/src/app/shared/components/feedback-form/feedback-form.dialog.spec.ts#L14
'matDialogRefSpy' is assigned a value but never used
|
Frontend Yarn Lint:
workspace/apps/pidp/src/app/shared/components/feedback-form/feedback-form.dialog.spec.ts#L27
Unexpected any. Specify a different type
|
Frontend Yarn Lint:
workspace/apps/pidp/src/app/shared/components/feedback-form/feedback-form.dialog.spec.ts#L28
Unexpected any. Specify a different type
|
Frontend Yarn Lint
Process completed with exit code 1.
|
helm-deployment
Canceling since a higher priority waiting request for 'Build All - PR - GOLD-refs/heads/PIDP-1094-User-feedback-button-on-PIDP' exists
|
helm-deployment
The operation was canceled.
|
get-pr-number
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
unit-test-backend
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
unit-test-backend:
backend/services.plr-intake/Program.cs#L59
The behavior of 'LoggerSinkConfiguration.Console([LogEventLevel],
|
unit-test-backend:
backend/services.plr-intake/Program.cs#L71
The behavior of 'LoggerSinkConfiguration.File(string,
|
unit-test-backend:
backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L38
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
unit-test-backend:
backend/webapi/Infrastructure/Services/PidpAuthorizationService.cs#L44
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Use 'string.IndexOf(char)' instead of 'string.IndexOf(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1866)
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
unit-test-backend:
backend/webapi/Features/Lookups/CommonEmailDomains.cs#L32
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
unit-test-backend:
backend/webapi/Features/Discovery/Discovery.cs#L61
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
unit-test-backend:
backend/webapi/Features/Discovery/Discovery.cs#L61
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
unit-test-backend:
backend/webapi/Features/EndorsementRequests/EmailSearch.cs#L33
Specify a culture or use an invariant version to avoid implicit dependency on current culture (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311)
|
Frontend Yarn Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
PLR Intake Backend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
WebAPI Backend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Frontend Build & Push
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|