Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUCY-1192] FEATURE** Add fields for bilge plugs #1193

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Jun 5, 2024

Note

My Linter went wild in these files, sorry in advance for there being 5x as many lines of changes as there should be :)

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [LUCY-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • PR Includes a migration to add two new boolean columns to Watercraft Risk Assessments (Inspections)
  • This is to assist in legislation for BC's Pull the Plug
  • This is the backend portion of the iOS Application side

Easiest way to test it

  1. Clone this repo
  2. Go to Prod or Dev branch
  3. From root run docker-compose -f docker-compose.dev.yml up -d to make docker images
  4. Switch to this branch
  5. Respin containers and see the migration take place
  6. Login to PGAdmin on Port:5050 and see the two new columns appear in the watercraft_risk_assessment table

image

@LocalNewsTV
Copy link
Collaborator Author

LocalNewsTV commented Jun 5, 2024

Dev is currently out of sync with prod due to hiccups with last season changes. I will need to address these

@LocalNewsTV LocalNewsTV marked this pull request as ready for review June 6, 2024 14:08
@LocalNewsTV LocalNewsTV linked an issue Jun 6, 2024 that may be closed by this pull request
2 tasks
@LocalNewsTV LocalNewsTV requested a review from a team June 6, 2024 16:35
@LocalNewsTV LocalNewsTV merged commit b93c965 into dev Jun 6, 2024
1 check passed
@LocalNewsTV LocalNewsTV deleted the 1192-bilge-plug-fields branch June 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new columns to Watercraft Risk Assessment table
2 participants