LCFS-1654: Protect routes for compliance report #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexZorkin
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Although your solution is workable, this adds an extra api call every time we open one of these views. A more efficient solution would be to use the existing validation files on the backend and check user permissions there. validation.py already uses compliance record so we have status available. Let me know what you think.
areyeslo
force-pushed
the
LCFS-1654-Protect-Routes-ComplianceReports
branch
from
d833eae to
f07e545
Compare
areyeslo
force-pushed
the
LCFS-1654-Protect-Routes-ComplianceReports
branch
from
f07e545 to
30717de
Compare
areyeslo
force-pushed
the
LCFS-1654-Protect-Routes-ComplianceReports
branch
from
30717de to
d793d7c
Compare
AlexZorkin
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has Government role and the compliance report status is "Draft" restrict access to the compliance report and its schedules to ensure they remain protected. The user is returned to /compliance-reporting
/compliance-reporting/:compliancePeriod/:complianceReportId/
/compliance-reporting/:compliancePeriod/:complianceReportId/supply-of-fuel
/compliance-reporting/:compliancePeriod/:complianceReportId/final-supply-equipments
/compliance-reporting/:compliancePeriod/:complianceReportId/allocation-agreements
/compliance-reporting/:compliancePeriod/:complianceReportId/notional-transfers
/compliance-reporting/:compliancePeriod/:complianceReportId/fuels-other-use
/compliance-reporting/:compliancePeriod/:complianceReportId/fuel-exports
Story