Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3771] Speed up maptile caching #3775

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[INV-3771] Speed up maptile caching #3775

merged 3 commits into from
Jan 7, 2025

Conversation

LocalNewsTV
Copy link
Collaborator

Overview

This PR includes the following proposed change(s):

  • Modify the download method of Map tiles to run a Concurrency limit of 10 instead of 1.
  • Modify the Download method to retry once on failure (previously 0)
  • Fix HTML Semantic Issue about missing tr in thead
  • add toLocaleString to tIlecounts to better display info (adds commas).
  • Increased time between Callback updates 200 -> 500ms
  • Closes Speed up Maptile caching. #3771

Its hard to establish how much the download speed will really improve by for Mobile when using a Simulator. Given the Simulator is constrained by my System the speed is much slower than the below.

Testing in Browser cached 205,587 tiles (2.8GiB) in 33:18.
Originally ~2300 tiles (36.7MiB) would take 2:34. Scaled up that translates to ~3.6 hours

(205k / 2,300) * 154sec / 60 / 60

Testing in a Simulator cached 1,000 tiles in 1:37
Originally 1,000 tiles would take 2:15
I'm not testing for high values because a simulator is more throttled than a physical device so the metrics mean less.
Based on the simulator this completes the same number of tiles in 71.85% of the time.

**During Caching I periodically navigated through the app testing for any noticeable slowdown, If you have the Network tab open you'll get some, due to how many Network requests are being logged, but if you don't, There isn't any..

}
}
}
const promises = tileUrls.map((config) => () => this.downloadTile(config));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@LocalNewsTV LocalNewsTV merged commit f053c53 into dev Jan 7, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up Maptile caching.
2 participants