Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3757] Clear Records from a Cache #3768

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Dec 31, 2024

Overview

This PR includes the following proposed change(s):

  • Implement a Frequency Map on Cache clear actions to avoid deleting records shared with other recordsets.
  • Fix issue where clearing a cache deletes ALL cached records.
  • Remove functionality around Cachelists as they were unused.
  • Trigger Cache delete when a Recordset is deleted to avoid dead recordsets being stored.
  • Closes Delete recordset cache deletes all caches #3757

EDITS

  • Convert RecordSet.remove to Recordset.requestRemoval now using Thunk.
  • Paginate deletion of records in Sqlite in batches of 100 with transactions
    • Tested caching 1000 records, Ran with an arbitrary error being thrown after 300 deletes to test transaction handling.
    • Validated Record counts in CLI

Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@plasticviking plasticviking merged commit 751b63c into dev Jan 3, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete recordset cache deletes all caches
2 participants