Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose map startup, move map into context, and refactor draw tools #3761

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

plasticviking
Copy link
Collaborator

Overview

This PR includes the following proposed change(s):

  • {List all the changes, if possible add the linked issue/ticket #}

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring / Documentation
  • Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots if applicable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
20.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Whats here Tool doesn't work
    image

  • Form Activity shape does work

  • Recordset Shapes no longer appearing on the Map

  • Drawn polygon nearly invisible (low opacity)

  • increasing the padding of the current draw mode box to padding: 2pt 5pt; would be a nice improvement

    • The Draw mode boxes positioning is awkward for screen real estate. if possible, something more akin to this so it takes over less space
    • Labels could be more user friendly. This will definitely be one of the first things the SOs note about the changes
  • Draw tools not duplicating!

image

I've also been getting this error (and in similar areas). I don't think its specific to your branch, but highlighting in case

image

Lots of console logs left, but assuming those will get removed after finalization

No comment or issues with code/styling stands out

@meghna0593
Copy link
Collaborator

I did not get errors for What's Here, however the functionality does not work as intended.

On toggling the recordset layer, I see this :
Screenshot 2024-12-24 at 12 52 04 PM

Neat breaking down of the map components!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants