Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3686] Whats Here Offline Workflow #3752

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

LocalNewsTV
Copy link
Collaborator

Overview

This PR includes the following proposed change(s):

  • Modify WhatsHere Sagas/reducers to handle pulling data from Cache storage
    • First compares the Bounding Box of a cached recordset before checking individual features of a recordset for matches
  • Cleanup code smells, remove dead code, simplify code
  • Add the activity_id to Cached GeoJSON for Feature filtering
  • Swap variable names from getBoundingBoxFromRecordSetFilters to be more consistent And because I had them wrong
  • Closes Mobile: Whats here button doesn't work for cached recordsets #3686

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@plasticviking plasticviking merged commit 65061b0 into dev Dec 17, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Whats here button doesn't work for cached recordsets
3 participants