update ministry names in code table, add news blurb, format news blurbs #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalNewsTV
reviewed
Dec 13, 2024
app/src/UI/Overlay/News/NewsPage.tsx
Outdated
Comment on lines
73
to
79
| <ul className="newsListItemContent"> | ||
| {newsItem.content.map((content: string, contentIndex: number) => ( | ||
| <li | ||
| key={contentIndex} | ||
| style={{ marginBottom: contentIndex < newsItem.content.length - 1 ? '1rem' : '0' }} | ||
| > | ||
| {renderContentWithLinks(content)} |
There was a problem hiding this comment.
Using index for array keys is a code smell
You can modify the CSS of the newsListItemContent with a css selector like
(from top of my head)
.newsListItemContent > li:not(:last-child){
margin-bottom: 1rem;
}There was a problem hiding this comment.
Little additional context one don't use array indexes as keys here
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes the following proposed change(s):
Type of change
if your change is a breaking change, please add
breaking changelabel to this PRHow Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots if applicable.
Checklist: