Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-N/A] Prune code in Records.tsx #3723

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[INV-N/A] Prune code in Records.tsx #3723

merged 1 commit into from
Nov 28, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

Overview

This PR includes the following proposed change(s):

Proposal: Remove these hooks to lower costly rerenders unless I am mistaken

Noticed that Records.tsx Had a lot of states/hooks wrapped that resulted in just loading a Spinner on a recordset
The addition of the spinner (and its representative states) didn't disable any functionality, or block anything from occuring.

No ticket assigned for this work. Side effect of other exploratory work.

@plasticviking plasticviking merged commit 18c11a0 into dev Nov 28, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants