Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INV-3679][INV-3681] Change Cache Text, Remove Cache Delete Button, Add Communication layers #3701

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

LocalNewsTV
Copy link
Collaborator

@LocalNewsTV LocalNewsTV commented Nov 20, 2024

Overview

This PR includes the following proposed change(s):

  • Combined functionality of the Delete/Download buttons for Recordset caching

  • Communications

    • Add Alerts for cache related subjects
    • Hook into Success/Fail cache actions to give alerts to user when actions finish/fail

Screenshots

Download Record Prompt (Delete one nearly identical)
image

Cached Buttons no longer have Underscores, NOT_CACHED prompt now 'SAVE'
image

Example Alert
image

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@plasticviking plasticviking merged commit eb47c5d into dev Nov 21, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Change NOT_CACHED text to "Save" or "Download" Mobile: Delete cache button should be trash can
2 participants