Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][INSPECT-252, INSPECT-283] - Fix to Inspection Validation #282

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

davidclaveau
Copy link
Contributor

@davidclaveau davidclaveau commented Jan 16, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Update validation to be included when attempting to go back to Shift Overview, preventing users from submitting unfinished inspections
  • Rework validation to be easier to read and add future validation as required.
  • Add additional documentation to validation code.
  • Update Journey Details to allow the user to add a Waterbody and a Major City when required.
    • This allows users to be more specific for waterbodies that stretch over large areas, and the Waterbody listed in the dropdown provides an incorrect city/province

@davidclaveau davidclaveau changed the title [FIX][INSPECT-252] - Fix to Inspection Validation [FIX][INSPECT-252, INSPECT-283] - Fix to Inspection Validation Jan 20, 2024
@davidclaveau davidclaveau merged commit 6d0e5de into master Jan 24, 2024
1 check passed
@davidclaveau davidclaveau deleted the feature/validation-rework branch January 24, 2024 17:59
@davidclaveau davidclaveau linked an issue Jan 26, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants