Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEN-950 | Undo-EoJ: Implement Logic for Re-Engage milestone #690

Merged
merged 9 commits into from
Dec 11, 2024
Merged

IEN-950 | Undo-EoJ: Implement Logic for Re-Engage milestone #690

merged 9 commits into from
Dec 11, 2024

Conversation

jerry-ey
Copy link
Collaborator

@jerry-ey jerry-ey commented Dec 10, 2024 •
edited
Loading

NOTED: This is merging to branch IEN-941 as it's continuing from re-engaged UI

  • add 3 events: Create, Update, Delete re-engaged milestone
  • These 3 events will trigger same service function which would go through complete_check and incomplete_check
  • Fixed PR feedback from branch 941

@jerry-ey jerry-ey marked this pull request as draft December 10, 2024 17:21
@jerry-ey jerry-ey marked this pull request as ready for review December 11, 2024 06:37
dbayly-freshworks
dbayly-freshworks approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@dbayly-freshworks dbayly-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, two small nits

apps/api/src/applicant/endofjourney.service.ts Outdated Show resolved Hide resolved
apps/api/src/applicant/endofjourney.service.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jerry-ey jerry-ey merged commit f63f4d7 into IEN-941 Dec 11, 2024
6 checks passed
@jerry-ey jerry-ey deleted the IEN-950 branch December 11, 2024 17:36
jerry-ey added a commit that referenced this pull request Dec 11, 2024
@jerry-ey @c1495616js
IEN-941 | [Undo EoJ] Create Re-Engage milestone (#687)
7d05dc4 
* add reengaged milestone

* add system milestone access permission

* fix formatting

* fix formatting

* fix formatting

* fix typescript

* fix sonarqube

* fix sonarqube duplication

* fix sonarqube further issue

* remove hintrc

* IEN-950 | Undo-EoJ: Implement Logic for Re-Engage milestone (#690)

* add logic

* fix formatting

* fix correct logic

* fix version

* fix yarn.lock

* remove unused code

* fix formatting

* fix formatting

* fix any type to correct type

---------

Co-authored-by: Jerry Wang <[email protected]>

---------

Co-authored-by: Jerry Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbayly-freshworks dbayly-freshworks dbayly-freshworks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerry-ey @dbayly-freshworks @c1495616js